Unzip ibsolution file #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicd/promote_solution.py
Outdated
| @@ -15,6 +15,10 @@ | |||
| from migration_helpers import download_ibsolution, compile_and_package_ib_solution, \ | |||
| download_dependencies_from_dev_and_upload_to_prod | |||
|
|
|||
| from dotenv import load_dotenv | |||
There was a problem hiding this comment.
What does load_dotenv do here?
There was a problem hiding this comment.
It will load in any environment variables stored in a .env file and if it doesn't exist does nothing, I've added a bit to the readme to explain
BNJHope
reviewed
May 1, 2024
Co-authored-by: Ben Hope <bnjhope1@gmail.com>
Co-authored-by: Ben Hope <bnjhope1@gmail.com>
Co-authored-by: Ben Hope <bnjhope1@gmail.com>
Co-authored-by: Ben Hope <bnjhope1@gmail.com>
BNJHope
approved these changes
May 9, 2024
Co-authored-by: Ben Hope <bnjhope1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
download_ibsolutionflag is set then also store the unzipped version of the ibsolution. If this is stored as part of a CI pipeline then version control of the code will be possibleAlso:
write_to_localto False when downloading ibsolution to upload to target environment