Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sample unit and integration tests for template #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mastersans
Copy link

Sample test files for gadget added to be used as template.

cc @mauriciovasquezbernal

Signed-off-by: mastersans <sanskarsharma3110@gmail.com>
@@ -8,6 +8,7 @@ Steps to use this template:
- Click on *Create repository*
- Update the placeholders (`git grep -i CHANGEME`, `git grep -i TODO`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update the placeholders (`git grep -i CHANGEME`, `git grep -i TODO`)
- Update the placeholders (`git grep -i CHANGEME`, `git grep -i TODO`, `git grep -i mytracer`)

Either update the grep commands, or rename to MyTracer to ChangeMeTracer in the go files.

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

Would you mind adding the corresponding targets to the Makefile too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants