Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOURCE-507 Attribute Enhancement in Azure Network Security Group Resource #680

Conversation

sa-progress
Copy link
Contributor

Signed-off-by: Samir Anand samiranand@Samirs-MacBook-Pro.local

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Signed-off-by: Samir Anand <samiranand@Samirs-MacBook-Pro.local>
@sa-progress sa-progress requested a review from a team as a code owner October 26, 2022 05:55
@sa-progress sa-progress self-assigned this Oct 26, 2022
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for inspec-azure ready!

Name Link
🔨 Latest commit a040e41
🔍 Latest deploy log https://app.netlify.com/sites/inspec-azure/deploys/63621eef45cc5d0008fe58e3
😎 Deploy Preview https://deploy-preview-680--inspec-azure.netlify.app/inspec/resources/azure_network_security_group
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…source

Signed-off-by: samir anand <samir.anand@progress.com>
…source

Signed-off-by: samir anand <samir.anand@progress.com>
…source

Signed-off-by: samir anand <samir.anand@progress.com>
@soumyo13 soumyo13 changed the title RESOURCE-507 added additional attribute for attribute RESOURCE-507 Attribute Enhancement in Azure Network Security Group Resource Oct 28, 2022
Signed-off-by: samir anand <samir.anand@progress.com>
Signed-off-by: samir anand <samir.anand@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintoncwolfe clintoncwolfe merged commit fd2d291 into main Nov 8, 2022
@clintoncwolfe clintoncwolfe deleted the RESOURCE-507-attribute-enhancement-in-azure-network-security-group-resource branch November 8, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants