-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESOURCE-507 Attribute Enhancement in Azure Network Security Group Resource #680
Merged
clintoncwolfe
merged 7 commits into
main
from
RESOURCE-507-attribute-enhancement-in-azure-network-security-group-resource
Nov 8, 2022
Merged
RESOURCE-507 Attribute Enhancement in Azure Network Security Group Resource #680
clintoncwolfe
merged 7 commits into
main
from
RESOURCE-507-attribute-enhancement-in-azure-network-security-group-resource
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samir Anand <samiranand@Samirs-MacBook-Pro.local>
✅ Deploy Preview for inspec-azure ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…source Signed-off-by: samir anand <samir.anand@progress.com>
…source Signed-off-by: samir anand <samir.anand@progress.com>
…source Signed-off-by: samir anand <samir.anand@progress.com>
soumyo13
changed the title
RESOURCE-507 added additional attribute for attribute
RESOURCE-507 Attribute Enhancement in Azure Network Security Group Resource
Oct 28, 2022
Signed-off-by: samir anand <samir.anand@progress.com>
Signed-off-by: samir anand <samir.anand@progress.com>
soumyo13
reviewed
Nov 2, 2022
docs-chef-io/content/inspec/resources/azure_network_security_group.md
Outdated
Show resolved
Hide resolved
soumyo13
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
clintoncwolfe
deleted the
RESOURCE-507-attribute-enhancement-in-azure-network-security-group-resource
branch
November 8, 2022 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samir Anand samiranand@Samirs-MacBook-Pro.local
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
rake lint
passes