Adding Logging Enabled Check to Azure Key Vault #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the diagnostic_settings_logs method doesn't sufficiently report whether logging is enabled or not. If any setting in the log block that is returned is not enabled (whether it signals that logging is enabled or not) the array reports a false flag. For this reason, the additional method was added to specifically check the field which signals that logging is enabled. |
Signed-off-by: Justin Nikles <justin.nikles@sap.com>
1b6ea47 to
8e0e27b
Compare
|
hi @sathish-progress - thanks for the suggestion. It's now implemented as suggested |
sathish-progress
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Nikles justin.nikles@sap.com
Description
Adds a check specifically for the AuditEvent log setting, which is set to true when logging is enabled https://docs.microsoft.com/en-us/azure/key-vault/general/howto-logging?tabs=azure-cli#enable-logging
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
rake lintpasses