Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support virtual nw gateway connections #531

Merged
merged 17 commits into from
Oct 28, 2021
Merged

Support virtual nw gateway connections #531

merged 17 commits into from
Oct 28, 2021

Conversation

sathish-progress
Copy link
Contributor

Description

Support Virtual Network Gateway Connection (s)

Issues Resolved

Check List

@sathish-progress
support azure virtual nw gateway
fe701eb 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
unit test azure virtual nw gateway
5ea9512 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
integral test azure virtual nw gateway
fc5c914 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
doc virtual nw gateway
54d9b4e 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
tf virtual nw gateway
d8cef2f 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
tf virtual nw gateway o/ps
2b9f4a1 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
update readme
46cfb4d 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
support azure virtual nw gateway connection(s)
952c595 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
unit test azure virtual nw gateway connection(s)
28d8d46 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
integral test azure virtual nw gateway connection(s)
153f90c 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
document azure virtual nw gateway connection(s)
6767ee4 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
tf support vnet gateway
082edf7 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
update readme for vnet gatway connection
7bddf3d 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
update docs
5756124 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
Merge branch 'support-azure-vitual-nw-gateways' into support-virtual-…
ea952f3 
…nw-gateway-connections
@sathish-progress sathish-progress requested review from a team as code owners October 20, 2021 08:54
@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Oct 20, 2021
sa-progress
sa-progress requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make those changes .Apart from that everything looks great.

docs/resources/azure_virtual_network_gateway_connections.md Outdated Show resolved Hide resolved
libraries/azure_virtual_network_gateway_connection.rb Show resolved Hide resolved
@sathish-progress
fix typo
f957c65 
Signed-off-by: Sathish <sbabu@progress.com>
sa-progress
sa-progress approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dkumaras
edits
0277102 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress merged commit 0e74ad3 into main Oct 28, 2021
@sathish-progress sathish-progress deleted the support-virtual-nw-gateway-connections branch October 28, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

@dkumaras dkumaras dkumaras approved these changes

@IanMadd IanMadd IanMadd approved these changes

Assignees
No one assigned
Labels
2021_PQ4 CFT Support Documentation ReadyForDocs Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sathish-progress @IanMadd @dkumaras @sa-progress