Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support migrate assessments machines #434

Merged
merged 13 commits into from
Nov 12, 2021
Merged

Support migrate assessments machines #434

merged 13 commits into from
Nov 12, 2021

Conversation

sathish-progress
Copy link
Contributor

Description

Support Azure Migrate Assessment Machine(s)

Issues Resolved

Check List

@sathish-progress
docs for azure migrate assessment machine (s)
7175301 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
unit test azure migrate assessment machine (s)
54b09e0 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
integral test azure migrate assessment machine (s)
03956d3 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
document azure migrate assessment machine (s)
52ac50e 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested review from a team as code owners August 16, 2021 05:06
sa-progress
sa-progress requested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Don't see terraform changes .Please check once.

docs/resources/azure_migrate_assessment_machine.md Show resolved Hide resolved
docs/resources/azure_migrate_assessment_machine.md Show resolved Hide resolved
docs/resources/azure_migrate_assessment_machine.md Outdated Show resolved Hide resolved
@sathish-progress
Merge branch 'master' of github.com:inspec/inspec-azure into support-…
382a9f4 
…migrate-assessments-machines
@sathish-progress
update docs
12f55da 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
refactor and filter table from response
a9daa4d 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
Copy link
Contributor Author

I Don't see terraform changes .Please check once.

No terraform available for this resource

sa-progress
sa-progress approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Sep 3, 2021
@IanMadd
Docs edits
ddc5de5 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@IanMadd IanMadd force-pushed the support-migrate-assessments-machines branch from f4d12dd to ddc5de5 Compare November 2, 2021 16:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress merged commit faa93f0 into main Nov 12, 2021
@sathish-progress sathish-progress deleted the support-migrate-assessments-machines branch November 12, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

@IanMadd IanMadd IanMadd approved these changes

Assignees
No one assigned
Labels
Documentation ReadyForDocs Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sathish-progress @IanMadd @sa-progress