Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Migrate Assessment Project (s) #426

Merged
merged 16 commits into from
Sep 16, 2021

Conversation

sathish-progress
Copy link
Contributor

Description

Support Azure Migrate Assessment Project (s)

Issues Resolved

Check List

Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested a review from a team as a code owner August 5, 2021 17:03
@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Aug 5, 2021
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested a review from a team as a code owner August 19, 2021 08:22
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback for @dkumaras


# azure_migrate_assessment_project

Use the `azure_migrate_assessment_project` InSpec audit resource to test the properties related to an Azure Migrate Assessment Project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment project should be lowercase.

`name` and `resource_group` are required parameters.

```ruby
describe azure_migrate_assessment_project(resource_group: 'MIGRATED_VMS', name: 'ZONEA_MIGRATE_ASSESSMENT_PROJECT') do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be more generic:

resource_group: 'RESOURCE_GROUP', name: 'ASSESSMENT_PROJECT_NAME'

docs/resources/azure_migrate_assessment_project.md Outdated Show resolved Hide resolved
docs/resources/azure_migrate_assessment_project.md Outdated Show resolved Hide resolved
docs/resources/azure_migrate_assessment_project.md Outdated Show resolved Hide resolved
sathish-progress and others added 6 commits September 13, 2021 12:09
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
@sathish-progress
Copy link
Contributor Author

@dkumaras , Could you please amend your signature to your commits that is causing the DCO to fail ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress merged commit 8aefb9b into main Sep 16, 2021
@sathish-progress sathish-progress deleted the support-azure-migrate-projects branch September 16, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants