Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account Storage Resource Fix #423

Merged
merged 11 commits into from
Aug 6, 2021
Merged

Account Storage Resource Fix #423

merged 11 commits into from
Aug 6, 2021

Conversation

sa-progress
Copy link
Contributor

@sa-progress sa-progress commented Aug 3, 2021 •
edited
Loading

Obvious fix; these changes are the result of automation not creative thinking.

Signed-off-by: sa-progress samir.anand@progress.com

Description

This PR is fix for account storage : filter name - has_recently_generated_access_key

  1. Account should regenerate new key if greater than 90 days .
  2. Regret key regenerate not required if account is newly created -- this case was failing. Filter was looking for regenerate call in all the cases.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

@chef-ci @sa-progress
Bump version to 1.52.0 by Chef Expeditor
dc41165 
Obvious fix; these changes are the result of automation not creative thinking.

Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress sa-progress requested a review from a team as a code owner August 3, 2021 15:42
@sathish-progress
Copy link
Contributor

This PR does not do what is says actually ..

@sa-progress
Copy link
Contributor Author

This PR does not do what is says actually ..

This PR is fix for account storage .For one use case when account storage is new, for one filter It was failing .
Use case 1>. Account should regenerate new key if greater than 90 days .
Use case2> Regret keygen not required if account is newly created -- this case was failing.

@sa-progress
Copy link
Contributor Author

This PR does not do what is says actually ..

This PR is fix for account storage .For one use case when account storage is new, for one filter It was failing .
Use case 1>. Account should regenerate new key if greater than 90 days .
Use case2> Regret keygen not required if account is newly created -- this case was failing.

Filter Name : has_recently_generated_access_key

@sathish-progress
Copy link
Contributor

No but this PR summary says about bumping version of chef expeditor .. Could you update the PR summary and details ?

@sa-progress sa-progress changed the title Bump version to 1.52.0 by Chef Expeditor Account Storage Resource Fix Aug 4, 2021
@sa-progress
linting fix
9b40542
@sa-progress
linting fix
58bfa9b 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
Merge branch 'f/account_storage_fix' of github.com:inspec/inspec-azur…
a55ce5f 
…e into f/account_storage_fix
@sathish-progress
Copy link
Contributor

@sa-progress should we update the docs for this with this change?

@sathish-progress sathish-progress added Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. bug labels Aug 5, 2021
sathish-progress
sathish-progress approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ppradhan9 ppradhan9 merged commit b973e05 into master Aug 6, 2021
@ppradhan9 ppradhan9 deleted the f/account_storage_fix branch August 6, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathish-progress sathish-progress sathish-progress approved these changes

Assignees
No one assigned
Labels
bug Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sa-progress @sathish-progress @ppradhan9 @chef-ci