-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/express circuit route #420
Conversation
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments & please update readme as well.
BTW, am not sure if the suffix *_resources
makes sense .. We could have simply gone with azure_express_route_circuit(s)
Signed-off-by: sa-progress <samir.anand@progress.com>
Yes Correct .I changed it . |
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
also please update readme |
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
| service_key | State of express circuitHostName creation | | ||
| stag | The identifier of the circuit traffic. Outer tag for QinQ encapsulation. | | ||
| global_reach_enabled | ExpressRoute circuit allowGlobalReachEnable `boolean` | | ||
| allow_global_reach | ExpressRoute circuit Flag denoting global reach status. `boolean` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is allow_global_reach
a valid property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes .Ian .Sending you the response :
{
"value": [
{
"name": "samir_circuit_route",
"id": "",
"etag": "W/"",
"type": "Microsoft.Network/expressRouteCircuits",
"location": "westus2",
"tags": {},
"properties": {
"provisioningState": "Updating",
"resourceGuid": "dsd2332ds",
"peerings": [],
"authorizations": [],
"serviceProviderProperties": {
"serviceProviderName": "AARNet",
"peeringLocation": "Sydney",
"bandwidthInMbps": 50
},
"circuitProvisioningState": "Disabled",
"allowClassicOperations": false,
"serviceKey": "000000 3939 0000-0000-000000000000",
"serviceProviderProvisioningState": "NotProvisioned",
"allowGlobalReach": false,
"globalReachEnabled": false
},
"sku": {
"name": "Standard_MeteredData",
"tier": "Standard",
"family": "MeteredData"
}
}
]
}
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
An `azure_express_route_circuits` resource block returns all Azure ExpressRoute circuits, either within a resource group or a subscription. | ||
|
||
```ruby | ||
describe azure_express_route_circuits(resource_group: 'RESOURCE_GROUP') do | ||
#... | ||
end | ||
``` | ||
|
||
or | ||
|
||
```ruby | ||
describe azure_express_route_circuits do | ||
#... | ||
end | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone double-check that this Syntax section is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ian,
Syntactically its correct and test cases also works this way but I will remove this, as I again checked in Api documentation They expect this resource by resource group only not subscription level.
So I am removing the example from document.
Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
rake lint
passes