Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/express circuit route #420

Merged
merged 37 commits into from
Aug 24, 2021
Merged

F/express circuit route #420

merged 37 commits into from
Aug 24, 2021

Conversation

sa-progress
Copy link
Contributor

@sa-progress sa-progress commented Jul 29, 2021

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Signed-off-by: sa-progress <samir.anand@progress.com>
…ure into f/express_circuit_route

Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress sa-progress requested a review from a team as a code owner July 29, 2021 11:34
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments & please update readme as well.

BTW, am not sure if the suffix *_resources makes sense .. We could have simply gone with azure_express_route_circuit(s)

libraries/azure_express_route_circuits_resources.rb Outdated Show resolved Hide resolved
docs/resources/azure_express_route_circuits_resources.md Outdated Show resolved Hide resolved
libraries/azure_express_route_circuits_resources.rb Outdated Show resolved Hide resolved
docs/resources/azure_express_route_circuits_resources.md Outdated Show resolved Hide resolved
docs/resources/azure_express_route_circuits_resources.md Outdated Show resolved Hide resolved
@sa-progress
Copy link
Contributor Author

minor comments & please update readme as well.

BTW, am not sure if the suffix *_resources makes sense .. We could have simply gone with azure_express_route_circuit(s)

Yes Correct .I changed it .

Signed-off-by: sa-progress <samir.anand@progress.com>
@sathish-progress
Copy link
Contributor

also please update readme

@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Aug 5, 2021
Signed-off-by: sa-progress <samir.anand@progress.com>
sa-progress and others added 10 commits August 9, 2021 11:43
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: sa-progress <samir.anand@progress.com>
| service_key | State of express circuitHostName creation |
| stag | The identifier of the circuit traffic. Outer tag for QinQ encapsulation. |
| global_reach_enabled | ExpressRoute circuit allowGlobalReachEnable `boolean` |
| allow_global_reach | ExpressRoute circuit Flag denoting global reach status. `boolean` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is allow_global_reach a valid property?

Copy link
Contributor Author

@sa-progress sa-progress Aug 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes .Ian .Sending you the response :

{
"value": [
{
"name": "samir_circuit_route",
"id": "",
"etag": "W/"",
"type": "Microsoft.Network/expressRouteCircuits",
"location": "westus2",
"tags": {},
"properties": {
"provisioningState": "Updating",
"resourceGuid": "dsd2332ds",
"peerings": [],
"authorizations": [],
"serviceProviderProperties": {
"serviceProviderName": "AARNet",
"peeringLocation": "Sydney",
"bandwidthInMbps": 50
},
"circuitProvisioningState": "Disabled",
"allowClassicOperations": false,
"serviceKey": "000000 3939 0000-0000-000000000000",
"serviceProviderProvisioningState": "NotProvisioned",
"allowGlobalReach": false,
"globalReachEnabled": false
},
"sku": {
"name": "Standard_MeteredData",
"tier": "Standard",
"family": "MeteredData"
}
}
]
}

@sa-progress sa-progress requested a review from IanMadd August 13, 2021 08:04
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
@sa-progress sa-progress requested a review from a team as a code owner August 13, 2021 21:57
Comment on lines 32 to 46
An `azure_express_route_circuits` resource block returns all Azure ExpressRoute circuits, either within a resource group or a subscription.

```ruby
describe azure_express_route_circuits(resource_group: 'RESOURCE_GROUP') do
#...
end
```

or

```ruby
describe azure_express_route_circuits do
#...
end
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone double-check that this Syntax section is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ian,

Syntactically its correct and test cases also works this way but I will remove this, as I again checked in Api documentation They expect this resource by resource group only not subscription level.
So I am removing the example from document.

Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress sa-progress requested a review from IanMadd August 18, 2021 06:49
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sa-progress and others added 2 commits August 19, 2021 11:48
Signed-off-by: sa-progress <samir.anand@progress.com>
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sa-progress sa-progress merged commit 9e2ff52 into master Aug 24, 2021
@sa-progress sa-progress deleted the f/express_circuit_route branch August 24, 2021 10:17
@lokeshk1987 lokeshk1987 linked an issue Sep 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express Circuit Route
3 participants