Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/express route #419

Merged
merged 23 commits into from
Aug 13, 2021
Merged

F/express route #419

merged 23 commits into from
Aug 13, 2021

Conversation

sa-progress
Copy link
Contributor

@sa-progress sa-progress commented Jul 28, 2021 •
edited
Loading

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

sa-progress and others added 8 commits July 28, 2021 11:31
@sa-progress
added resource and test cases
f1ef9e6
@sa-progress
added resource and test cases
16a2335 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
lint fix
d521664
@ppradhan9
added test space
90a2464 
Signed-off-by: ppradhan9 <ppradhan@progress.com>
@sa-progress
updated resource
5a25c07
@sa-progress
fixed merge conflict
fe8b19d
@sa-progress
fixed merge conflict
eadabda 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
Merge branch 'f/express_route' of github.com:inspec/inspec-azure into…
9bb9d28 
… f/express_route
@sa-progress sa-progress requested a review from a team as a code owner July 28, 2021 14:34
@sa-progress
merge fixed
6c04d5a 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress sa-progress self-assigned this Jul 28, 2021
@sathish-progress
Copy link
Contributor

any reason for no singular resource ?

@sathish-progress
Copy link
Contributor

also please update readme

@sa-progress
Copy link
Contributor Author

any reason for no singular resource ?

These are Listing provided by Azure .Only Plural ones are available.

@sathish-progress sathish-progress added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Jul 29, 2021
@sa-progress
Copy link
Contributor Author

also please update readme

Done.

@sa-progress
updated read me
c4f8cb5 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sathish-progress
Copy link
Contributor

also please update readme

Done.

for this I meant you have to update this readme

@sa-progress
Copy link
Contributor Author

also please update readme

Done.

for this I meant you have to update this readme

Yes .I updated The same.

sa-progress and others added 2 commits July 29, 2021 18:23
@sa-progress
read me updated
1384bff 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
Merge branch 'master' into f/express_route
18d5367
sathish-progress
sathish-progress reviewed Jul 29, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
sathish-progress
sathish-progress reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppradhan9 ppradhan9 requested a review from IanMadd August 5, 2021 06:12
sathish-progress
sathish-progress approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IanMadd
IanMadd reviewed Aug 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@sa-progress sa-progress requested a review from a team as a code owner August 12, 2021 06:01
sa-progress and others added 4 commits August 12, 2021 11:41
@sa-progress
Merge branch 'master' into f/express_route
1e40bca
@sa-progress
added Reqd me and tf files
b97dce8 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
Merge branch 'f/express_route' of github.com:inspec/inspec-azure into…
f7aadeb 
… f/express_route
@sa-progress
added Reqd me and tf files
6a72650 
Signed-off-by: sa-progress <samir.anand@progress.com>
@sa-progress
Copy link
Contributor Author

@IanMadd I have made those changes .
can you please approve this pr.
thanks.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sa-progress sa-progress merged commit 6f557a5 into master Aug 13, 2021
@sa-progress sa-progress deleted the f/express_route branch August 13, 2021 11:55
@ppradhan9 ppradhan9 linked an issue Sep 24, 2021 that may be closed by this pull request
Express routes #497
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathish-progress sathish-progress sathish-progress approved these changes

@IanMadd IanMadd IanMadd approved these changes

Assignees

@sa-progress sa-progress

Labels
Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Express routes
4 participants
@sa-progress @sathish-progress @IanMadd @ppradhan9