Support ad directory objects #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
soumyo13
reviewed
Jul 22, 2021
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
fa6512c to
40c4182
Compare
IanMadd
approved these changes
Jul 28, 2021
Please review again.. |
…ad-directory-objects
sa-progress
approved these changes
Aug 5, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
soumyo13
reviewed
Aug 6, 2021
| } | ||
|
|
||
| variable "sample_directory_object" { | ||
| default = "adc07321-ef2b-44d5-a210-559aa5f10f2d" |
There was a problem hiding this comment.
Do we have to specify the hardcoded value? In AWS we specify the hardcoded values in test/integration/configuration/aws_inspec_config.rb
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support ad directory objects
Issues Resolved
#391
Check List
rake lintpasses