Support azure functions resource #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/verify/controls/azure_web_app_function_test.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall, this is great work. Clearly you've put in a lot of effort into testing and making sure that the TF code works.
There are some rough spots in the documentation that need to be smoothed out but I will leave that in the capable hands of the Docs team.
This looks great in reading, but I hesitate to approve because I am not an Azure expert and I would not want to imply that it is more solid than it actually is - you'll need to rely on your own testing for that. But it contains all the parts I would expect in a cloud resource pack new resource PR, and it is well enough done.
Good work!
d3d9812 to
3a3325a
Compare
|
@IanMadd Could you please review this one? |
|
I made some edits to the two docs pages. Can you just verify that my edits are correct. |
7 tasks
ppradhan9
approved these changes
Jun 7, 2021
Singualar resource of Azure of functions Signed-off-by: Sathish <sbabu@progress.com> support listing of azure web app functions Plural resource of Azure functions Signed-off-by: Sathish <sbabu@progress.com> test resources for web app functions Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> integrate tf azure app function app Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> use valid keys for parameters & identifiers Signed-off-by: Sathish <sbabu@progress.com> update comments and remove table schema kinds Signed-off-by: Sathish <sbabu@progress.com> store local functionapp Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> tf storage blob Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> rename web_app_function & web_app_functions integrations Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> document web_app functions resource Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com> output function app related variables Signed-off-by: Sathish <sbabu@progress.com> fix bring back outputs Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
f089bc3 to
cfb5b70
Compare
Nirbhay1997
approved these changes
Jun 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add azure_web_app_function(s) resources
Issues Resolved
#373
Check List
rake lintpasses