Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dependabot to check ruby gems #355

Merged
merged 1 commit into from
May 6, 2021
Merged

Allow dependabot to check ruby gems #355

merged 1 commit into from
May 6, 2021

Conversation

jlosito
Copy link
Contributor

@jlosito jlosito commented Dec 24, 2020

Description

This change allows dependabot to check ruby related dependencies which this project uses and automatically submit PRs with version bumps in order to keep packages up-to-date. Below is a link to dependabot's documentation.

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates

Issues Resolved

There aren't any related issues that I know of.

Check List

I believe apart of PRs, GitHub has a feature where there's a dependabot validator which checks to make sure dependabot configuration files are syntactically correct.

I'm not too sure if the boxes left unchecked are related to this type of change.

@jlosito jlosito marked this pull request as ready for review December 24, 2020 13:30
@jlosito jlosito requested a review from a team as a code owner December 24, 2020 13:30
@sathish-progress
Copy link
Contributor

Could you rebase from master?

Signed-off-by: John Losito <lositojohnj@gmail.com>
@jlosito
Copy link
Contributor Author

jlosito commented May 6, 2021

@sathish-progress I've rebased off of master and also signed my commit though you might want to reject this pull request now that I see #380 was created.

@sathish-progress
Copy link
Contributor

@sathish-progress I've rebased off of master and also signed my commit though you might want to reject this pull request now that I see #380 was created.

I would prefer to merge this PR considering it has all checks passed with valid DCO and for the effort you have put in .. :)

Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sathish-progress sathish-progress merged commit d00694a into inspec:master May 6, 2021
@jlosito jlosito deleted the dependabot-config branch May 6, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants