Update contribution guide with the usage of new backend #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Demirok <odemirok@chef.io>
srb3
reviewed
Oct 22, 2020
There was a problem hiding this comment.
The resource creation guide is really comprehensive, only a minor point about a definition for static resources.
Structure wise maybe add a table of contents to the readme would make it easier to pick out the bits of information a person requires, the main readme is a bit long to grok at first glance, for me anyway.
rmoles
reviewed
Oct 22, 2020
rmoles
reviewed
Oct 22, 2020
|
Great work @omerdemirok. I agree with @srb3, it would be good to add a table of contents for the contribution guide. |
f31647f to
81b065e
Compare
Signed-off-by: Omer Demirok <odemirok@chef.io>
81b065e to
3095d47
Compare
rmoles
reviewed
Oct 28, 2020
Signed-off-by: Omer Demirok <odemirok@chef.io>
2649114 to
56dee99
Compare
rmoles
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omer Demirok odemirok@chef.io
Description
Issues Resolved
N/A
Check List
rake lintpasses