rewrite storage account to new generic resource way (WIP) #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srb3 <sbrown@chef.io>
4 tasks
Signed-off-by: srb3 <sbrown@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
added 2 commits
November 9, 2020 14:49
Signed-off-by: Omer Demirok <odemirok@chef.io>
…e into convert_storage_account
rmoles
reviewed
Nov 9, 2020
rmoles
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Thanks @srb3 & @omerdemirok this looks good to go apart from one name change 🎉
Signed-off-by: Omer Demirok <odemirok@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: srb3 sbrown@chef.io
Description
converts the storage account resources to the azure generic resource
This is WIP as it is currently blocked by at least #323