Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment parameters #290

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Fix environment parameters #290

merged 3 commits into from
Sep 7, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

Check forward slashes when constructing a url.

Issues Resolved

Fixes #289 🤞

Check List

Omer Demirok added 2 commits September 7, 2020 11:22
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 7, 2020 10:42
libraries/azure_backend.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment could be removed, but apart from that looks good to go.

Signed-off-by: Omer Demirok <odemirok@chef.io>
@rmoles rmoles merged commit d078580 into master Sep 7, 2020
@rmoles rmoles deleted the fix_environment_parameters branch September 7, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad URL is used when endpoint is set for non-default Azure Cloud
2 participants