Remove left-over folder created at rake lint task
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rake lint` runs `inspec vendor` command before syntax check and this creates a `vendor` folder with the dependencies in it. A second `rake lint` task detects the style issues in the `vendor` file and fails the `lint` task. It should be removed after syntax check. Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omer Demirok odemirok@chef.io
Description
rake lintrunsinspec vendorcommand before syntax check and this creates avendorfolder with the dependencies in it.A second
rake linttask detects the style issues in thevendorfile and fails thelinttask.It should be removed after syntax check.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
rake lintpasses