NSG resource Fixes and Webapp resources added #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skelleyton <skelleyton@gmail.com>
This reverts commit 35b800f. Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com> Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
|
@skelleyton aiming to get one of the team onto this PR in the next 2 weeks |
|
Thanks - I am also very interested with this PR for use inspec for web app |
|
It can handle function app as well ? |
|
This PR does not handle Functions, just Web Apps. |
ghost
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Great addition @skelleyton - I look forward to merging it once you've merged in master/rebased to resolve conflicts & addressed the very minor comments added.
Thanks again for this contribution.
Corrected typo in the azurerm_webapps.rb example. Modified integration test for azurerm_webapps to test for specific webapp resource. Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
Signed-off-by: skelleyton <skelleyton@gmail.com>
|
Thanks @skelleyton |
ghost
approved these changes
Sep 30, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes in azurerm_network_security_group to property scan rules that have multiple source IP addresses and multiple destination ports.
Resources added for Webapp and Webapps. Added POST HTTP method to use the authentication settings call for Webapps.
Issues Resolved
#169
Check List
rake lintpasses