Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lib for load balancer and network interface #161

Merged
merged 49 commits into from
Jan 30, 2020
Merged

Add lib for load balancer and network interface #161

merged 49 commits into from
Jan 30, 2020

Conversation

mikaelkrief
Copy link
Contributor

Description

Add librairies for:

  • load balancer(s)
  • network interface(s)

with lib, terraform, tests, docs and readme update with doc links

@mikaelkrief
update gitignore
d133a59
@mikaelkrief
Add mysql servers lib test
50f7a3c
@mikaelkrief
add test for mysql database
29c9f6c
@mikaelkrief
add test for mysql database
035e6a6 
Signed-off-by: root <root@DESKTOP-9Q2U73J.localdomain>
@mikaelkrief
Merge branch 'master' of https://github.com/mikaelkrief/inspec-azure
f89af67
@mikaelkrief
Merge branch 'master' of https://github.com/mikaelkrief/inspec-azure
ef4c360 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
Merge branch 'master' of https://github.com/mikaelkrief/inspec-azure
d5424ea
@mikaelkrief
fix lint errors
5e9e252 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
update resource creation guide
6f0a338 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
Add lib for Load balancer & Load balancers
63467c2 
Inprove some markdown

Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
add lib for Network interface
1fede39 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
update readme with docs links
6184d34 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief mikaelkrief requested a review from a user January 15, 2019 16:33
@mikaelkrief
fix lint
f41f450 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
fix review of PR
2ae9439
ghost
ghost suggested changes Jan 24, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikaelkrief

Thanks again for these contributions. As with PR-160, I look forward to adding these new resources to the Inspec-Azure resource pack. I've left some change requests before we can merge.

I haven't addressed the MySQL resources, deocumentation and tests added in this PR as I addressed them in PR-160. I would recommend merging your mikaelkrief/inspec-azure:master branch into this branch (mikaelkrief/inspec-azure:master2), and then closing PR-160 as this PR covers both.

If you require clarification or wish to discuss any of the feedback please feel free to reply directly or reach out on the Chef Community Slack.

Ruairi

Rakefile Outdated Show resolved Hide resolved
docs/resources/azurerm_load_balancer.md.erb Show resolved Hide resolved
docs/resources/azurerm_load_balancer.md.erb Outdated Show resolved Hide resolved
docs/resources/azurerm_load_balancers.md.erb Outdated Show resolved Hide resolved
docs/resources/azurerm_load_balancers.md.erb Outdated Show resolved Hide resolved
docs/resources/azurerm_network_interfaces.md.erb Outdated Show resolved Hide resolved
docs/resources/azurerm_network_interfaces.md.erb Outdated Show resolved Hide resolved
docs/resources/azurerm_network_interfaces.md.erb Show resolved Hide resolved
libraries/support/azure/management.rb Outdated Show resolved Hide resolved
terraform/azure.tf Outdated Show resolved Hide resolved
@mikaelkrief
Copy link
Contributor Author

@r-fennell , I updated my PR with the fixes of your great feedbacks

@josh-barker
Copy link

Hey @mikaelkrief, I'd love to use these resources, but the conflicting terraform files will stop the merge.

Could you take a look at resolving the conflicts?

@mikaelkrief mikaelkrief requested a review from a team May 8, 2019 18:53
@mikaelkrief
Copy link
Contributor Author

@josh-barker , I fixed the merge issue

@ghost ghost mentioned this pull request Jul 11, 2019
Closed
@mikaelkrief
Copy link
Contributor Author

@rmoles , Done conflicts resolved

@mikaelkrief
fixed wording in documentation
3416762 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
Upgrade version documentation
92e9bce 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
rmoles
rmoles reviewed Oct 31, 2019
View reviewed changes
Rakefile Outdated Show resolved Hide resolved
@mikaelkrief
remove duplicate Task
0a0d00c 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
remove duplicate line
d40c8be 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@mikaelkrief
add blank line at the end of file
a8a0fbb 
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
@rmoles rmoles requested a review from a user October 31, 2019 14:32
rmoles
rmoles approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time on this @mikaelkrief. This looks good to go to me 😄.

@mikaelkrief
Copy link
Contributor Author

@r-fennell could you review this PR ?

ghost
ghost reviewed Nov 28, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikaelkrief - Thanks again for following up with this contribution. It looks much better now. @inspec/inspec-cloud-devs maintain this repo now so I will leave the final approval & merge to them!
Thanks again.

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Jan 21, 2020
rmoles
rmoles suggested changes Jan 29, 2020
View reviewed changes
terraform/azure.tf Outdated Show resolved Hide resolved
rmoles
rmoles reviewed Jan 29, 2020
View reviewed changes
terraform/azure.tf Outdated Show resolved Hide resolved
@rmoles rmoles dismissed ghost ’s stale review January 29, 2020 17:03

as per r-fennels comment. The final approval should be from inspec/inspec-cloud-devs

@rmoles rmoles requested a review from a team January 29, 2020 17:04
@mikaelkrief
Copy link
Contributor Author

thanks @rmoles

skpaterson
skpaterson approved these changes Jan 30, 2020
View reviewed changes
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikaelkrief and @rmoles !

@skpaterson skpaterson merged commit ee8c86f into inspec:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skpaterson skpaterson skpaterson approved these changes

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikaelkrief @josh-barker @edwardbartholomew @avishnyakov @rmoles @skpaterson