Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle encoded urls on jsonLD exposition endpoint #1757

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

rpanfili
Copy link
Contributor

This should fix both
#1755
#1756

Copy link
Member

@ziodave ziodave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to install the pre-commit hook and run composer run format and composer run lint to ensure the code abides to the WP PHP Coding Standards.

src/classes/jsonld/class-jsonld-endpoint.php Outdated Show resolved Hide resolved
@rpanfili rpanfili force-pushed the jsonld_fix branch 2 times, most recently from 0cf0cf5 to 6fccca4 Compare January 14, 2025 18:07
@rpanfili rpanfili requested a review from ziodave January 14, 2025 18:09
@rpanfili rpanfili force-pushed the jsonld_fix branch 3 times, most recently from 208e966 to 8fef1cb Compare January 14, 2025 18:31
@rpanfili
Copy link
Contributor Author

You need to install the pre-commit hook and run composer run format and composer run lint to ensure the code abides to the WP PHP Coding Standards.

I noticed that husky node package is required to automate this pre-commit installation.
Since this is mainly a php project you may prefer a project like grumphp to achieve the same. As per node, pre-commit installation will happen executing just composer install.

@ziodave ziodave merged commit 3e806ae into insideout10:main Jan 15, 2025
29 checks passed
@ziodave ziodave deleted the jsonld_fix branch January 15, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants