Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supabase_chat_core.dart #11

Merged

Conversation

danbeech
Copy link
Contributor

What does it do?

First of all, sorry about the formatting changes 😬 The change uses epoch millis for updatedAt in method SupabaseChatCore.instance.updateRoom instead of DateTime.now()

Why is it needed?

You cannot update a room when providing a flutter DateTime type in the call.

How to test it?

Try to update a room before this change, look at the error. Then use this PR and your room will update 👍

Related issues/PRs

Nope, just fixing it.

@rickypid
Copy link
Contributor

hi @danbeech,

Thank you for your contribution, I would kindly ask you to:

  • Run dart format .
  • Edit the file CHANGELOG.md

Thank you.

@danbeech
Copy link
Contributor Author

@rickypid No problem, I'll update with these changes later on 👍

@danbeech
Copy link
Contributor Author

@rickypid updates done, anything else just lmk 🙌

@rickypid rickypid added the bug Something isn't working label Oct 26, 2024
@rickypid rickypid merged commit 0bdfa89 into insideapp-srl:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants