This re-enables package import tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These had been disabled until the package was published on NPM, and mistakingly hadn't been re-enabled.
This prevents the bahaviour documented in ezolenko/rollup-plugin-typescript2#170 from happening. Namely, a _virtual/tslib.js file would be emitted, which confuses NodeJS because we expect all ES modules to have the .mjs extension. The previous syntax feels more elegant though, so I think it should be re-enabled once the bug is resolved. Also, there's no guarantee that this issue can alway be worked around so easily. Issue tracking is available at ezolenko/rollup-plugin-typescript2#282.
5674008 to
e60ed68
Compare
Trying to import the package in an environment where it's not available causes Webpack to fail. Until a proper fix is found, this works around the issue by simply not trying to auto-import the @inrupt/solid-client-authn package.
5f47afc to
59d62df
Compare
ajacksified
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These had been disabled until the package was published on NPM, and
mistakingly hadn't been re-enabled.