Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #117 and #119 #120

Closed
wants to merge 1 commit into from
Closed

Conversation

nh2
Copy link
Member

@nh2 nh2 commented Aug 24, 2018

See #117 and #119.

As of writing, my build to test it fixes #117 is still running.

@nh2
Copy link
Member Author

nh2 commented Aug 24, 2018

As of writing, my build to test it fixes #117 is still running.

Build failed, so I'll split this. Please merge #121 first.

@nh2 nh2 force-pushed the nh2fixes-2018-08-25 branch from 05a76be to d2f8da4 Compare August 25, 2018 00:46
@nh2
Copy link
Member Author

nh2 commented Aug 25, 2018

Build failed, so I'll split this

Now it should be good.

And I've tested that it fixes #117 (comment) for me.

@nh2 nh2 force-pushed the nh2fixes-2018-08-25 branch from d2f8da4 to b8668e1 Compare August 25, 2018 12:08
@nh2
Copy link
Member Author

nh2 commented Aug 25, 2018

Rebased.

Last build travis complained that there was no cabal2nix-2.11 in the database, did you run cabal update? Odd.

@domenkozar
Copy link
Contributor

You need to bump timestamp in stack2nix updating script.

@infinisil
Copy link

Ping? I need the fix for #117

@nh2 nh2 force-pushed the nh2fixes-2018-08-25 branch from b8668e1 to b56ea06 Compare September 3, 2018 13:18
@nh2
Copy link
Member Author

nh2 commented Sep 3, 2018

You need to bump timestamp in stack2nix updating script.

Like this?

@domenkozar
Copy link
Contributor

Yeah :( Until we fix #126

@domenkozar
Copy link
Contributor

You also need to commit the new stack2nix output :)

@domenkozar domenkozar added this to the 0.3 milestone Sep 4, 2018
@domenkozar
Copy link
Contributor

Pushed to master, thanks.

@domenkozar domenkozar closed this Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to recognise the license in stack new simple-library template.
3 participants