[ETCM-631] Create peerId from node's public key #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-bogastry
approved these changes
Apr 7, 2021
milenkara
approved these changes
Apr 7, 2021
3f188fd to
19eac46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The node's public key is encoded in the username part of ts URI.
enode://pubkey@ip:portThis PR makes use of this node Id to derive a PeerId
Proposed Solution
Currently, a PeerId is created from the
PeerActor's path. This is changed to create a Peer Id from the Node's pub key.Important Changes Introduced
PeerId is unknown for nodes that are not yet handshaked. Currently, they are named
PendingPeers.See: PeerManagerActor and ConnectedPeers.
Pending peers were stored using Id derived from PeerActor path until successfully handshaked.
Testing
Unit tests and it tests