ETCM-719: Remove header work queue from persisted state and fix final header skeleton size #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
5100
to5200
and our max batch size is30
the request that would be made would have been to get 4 headers with a gap of 30 - so we're actually requesting up to5220
which the peer might not have. In that case it would send us back only 3 headers which would fail our validation (because we expect 4).waiting for [0] requests
when it was actually waiting for the header skeletonProposed Solution
limit
so it would only request 3 headers in the example above, so the header skeleton would contain headers5100
to5190
. After that a new skeleton would be requested with one batch of size 10.Testing
HeaderSkeleton