Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-622] Update the README with a section on how to config and test the Faucet #917

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

leo-bogastry
Copy link
Contributor

Description

Update the README with a section on how to config and test the Faucet

Proposed Solution

Added a section on how to setup and test the Faucet locally.
Rewrote some parts that I think that were not very clear

README.md Show resolved Hide resolved
@leo-bogastry leo-bogastry force-pushed the feature/ETCM-622-document-faucet branch from 4fdbeb9 to 67875fd Compare February 5, 2021 13:15
README.md Outdated
sbt -Dconfig.file=src/universal/conf/faucet.conf "run faucet"
```

6. Run the following curl command to send money from your faucet to a wallet address:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: money => tokens ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need to improve my blockchain vocabulary :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed

@leo-bogastry leo-bogastry force-pushed the feature/ETCM-622-document-faucet branch from 67875fd to 1449948 Compare February 8, 2021 09:59
Copy link
Contributor

@1015bit 1015bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 I left some comments (mostly minor).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@leo-bogastry leo-bogastry force-pushed the feature/ETCM-622-document-faucet branch from 1449948 to 5ec51a7 Compare February 8, 2021 13:29
Copy link
Contributor

@1015bit 1015bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leo-bogastry leo-bogastry merged commit 2f61024 into develop Feb 8, 2021
@leo-bogastry leo-bogastry deleted the feature/ETCM-622-document-faucet branch February 8, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants