Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETCM-546] The unsafe usage of maxBy (BlockQueue) #910

Merged
merged 1 commit into from
Jan 28, 2021
Merged

[ETCM-546] The unsafe usage of maxBy (BlockQueue) #910

merged 1 commit into from
Jan 28, 2021

Conversation

pslaski
Copy link
Contributor

@pslaski pslaski commented Jan 28, 2021

Description

Sometimes testnet nodes throw java.lang.UnsupportedOperationException: empty.maxBy because of unsafe usage of maxBy on empty collection in BlockQueue.updateChainWeights

@pslaski pslaski requested a review from dzajkowski January 28, 2021 13:04
@pslaski pslaski force-pushed the etcm-546-unsafe-block-queue branch from d633ab8 to e79fd44 Compare January 28, 2021 13:09
@pslaski pslaski merged commit 4c8491d into develop Jan 28, 2021
@pslaski pslaski deleted the etcm-546-unsafe-block-queue branch January 28, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinraju robinraju robinraju approved these changes

@dzajkowski dzajkowski dzajkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pslaski @dzajkowski @robinraju