Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Trigger block execution metrics on reorg as well #835

Merged
merged 2 commits into from
Dec 7, 2020
Merged

[FIX] Trigger block execution metrics on reorg as well #835

merged 2 commits into from
Dec 7, 2020

Conversation

ntallar
Copy link

@ntallar ntallar commented Dec 4, 2020

Description

Measure block execution metrics on reorg as well.

The current measuring point is only part of the possible paths of blocks execution, meaning that some imported blocks are currently not measured

@ntallar ntallar requested a review from pslaski December 4, 2020 18:38
@ntallar ntallar added the high priority This PRs should be reviewed and merged ASAP label Dec 4, 2020
SoseMagarian
SoseMagarian approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@SoseMagarian SoseMagarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pslaski pslaski merged commit 94d108e into develop Dec 7, 2020
@pslaski pslaski deleted the fix/checkpointing-metrics branch December 7, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoseMagarian SoseMagarian SoseMagarian approved these changes

@pslaski pslaski pslaski approved these changes

Assignees
No one assigned
Labels
high priority This PRs should be reviewed and merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntallar @pslaski @SoseMagarian