[ETCM-403] Expose application.conf and chains configs directory #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
reviewed
Nov 27, 2020
| @@ -1,5 +1,5 @@ | |||
| # This is the base configuration file for the Mantis ETC client. | |||
There was a problem hiding this comment.
maybe is a good time to get rid of this file(app.conf). IMO is just a useless proxy.
There was a problem hiding this comment.
(disclaimer: probably out of scope)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy all configs to the package conf directory - it will be easier to understand for users how to configure the client.