Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Update testnet internal configs #801

Merged
merged 4 commits into from
Nov 19, 2020
Merged

[Chore] Update testnet internal configs #801

merged 4 commits into from
Nov 19, 2020

Conversation

ntallar
Copy link

@ntallar ntallar commented Nov 17, 2020

Description

Updates configurations due to requirements from both gac and nomad testnets:

  • Updated gac's genesis with new address
  • Configured genesis + bootstrap for connecting to the nomad testnet

Proposed Solution

As both gac and nomad testnet are diverging (different bootstrap and genesis), totally separate configurations will be used for them.

Testing

  • Start Mantis with testnet-internal-nomad configured and see that the node starts syncing to the testnet

@ntallar ntallar requested review from mmrozek and kapke November 17, 2020 18:41
mmrozek
mmrozek approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as expected

@ntallar ntallar mentioned this pull request Nov 18, 2020
Merged
@ntallar ntallar mentioned this pull request Nov 18, 2020
Merged
@ntallar ntallar merged commit 057f84c into develop Nov 19, 2020
@ntallar ntallar deleted the chore/update-config-testnet-internal branch November 19, 2020 14:18
@ntallar ntallar added the BREAKS CONFIG Affects the default configuration label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrozek mmrozek mmrozek approved these changes

@kapke kapke Awaiting requested review from kapke

Assignees
No one assigned
Labels
BREAKS CONFIG Affects the default configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntallar @mmrozek