[ETCM-198] Update fastsync to request headers only from peers with be… #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6684885 to
bfd810d
Compare
added 2 commits
October 28, 2020 09:25
…st block >= pivot block
bfd810d to
b09854f
Compare
|
PR tested. Mantis synced with etc mainnet without problems |
kapke
reviewed
Oct 28, 2020
| peers | ||
| .take(maxConcurrentRequests - assignedHandlers.size) | ||
| .toSeq | ||
| .sortBy(_.ref.toString()) | ||
| .sortBy(_.info.maxBlockNumber)(Ordering[BigInt].reverse) | ||
| .foreach(assignBlockchainWork) |
There was a problem hiding this comment.
Very minor - why not adding the block height condition here?
KonradStaniec
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st block >= pivot block
Description
Request headers from peers having best block higher than our pivot block should decrease the possibility of following the wrong fork