Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-202] Fix address derivation command #753

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Oct 22, 2020

Description

Fix address derivation (address length)

@mmrozek mmrozek requested a review from kapke October 22, 2020 07:37
@@ -62,8 +63,9 @@ object CliCommands {

private def privKeyToAddress(privKey: Array[Byte]): String = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be now Address.fromPrivateKey?

Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmrozek mmrozek merged commit 69932a3 into develop Oct 22, 2020
@mmrozek mmrozek deleted the etcm-202-mantis-cli branch October 22, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants