[ETCM-202] Provide Mantis command-line interface #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Oct 20, 2020
kapke
reviewed
Oct 20, 2020
| val generatePrivateKeyCommand = "generate-private-key" | ||
| val deriveAddressCommand = "derive-address" | ||
| val generateAllocsCommand = "generate-allocs" | ||
| val useAddressesFlag = "useAddresses" |
There was a problem hiding this comment.
why not replace it with either --address=<address> or --key=<key (or in plural)? In that way it would be a bit easier and always clear what is passed without reaching for bool flags
kapke
reviewed
Oct 20, 2020
| @@ -17,6 +18,7 @@ object App extends Logger { | |||
| val mallet = "mallet" | |||
| val faucet = "faucet" | |||
| val ecKeyGen = "eckeygen" | |||
| val cli = "mantis-cli" | |||
There was a problem hiding this comment.
why not just cli if not separate launcher is created?
e32f446 to
ed84de0
Compare
3892874 to
659e94f
Compare
659e94f to
8f5e412
Compare
kapke
reviewed
Oct 21, 2020
|
|
||
| object Fixture { | ||
|
|
||
| def argument(name: String, value: Option[Any] = None): String = s"--$name${value.fold("")(v => s"=${v.toString}")}" |
There was a problem hiding this comment.
very minor in current state - that Any there, it's fine now, but I'd consider using just String instead so any conversion needs to happen explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLI to mantis. Options: