[ETCM-126] add eth_pendingTransactions #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it works the same as |
added 2 commits
October 9, 2020 13:43
…ove qa_getPendingTransactions
23e77bc to
5f00f21
Compare
Signed-off-by: lemastero <piotr.paradzinski@iohk.io>
…ctions Signed-off-by: lemastero <piotr.paradzinski@iohk.io>
fea3bd8 to
7d47ca3
Compare
mmrozek
reviewed
Oct 12, 2020
| response should haveResult(JArray(List())) | ||
| } | ||
|
|
||
| it should "mempool is empty" in new TestSetup { |
There was a problem hiding this comment.
Mempool has transactions here
There was a problem hiding this comment.
Good catch, thank you it gave me some good hint on why tests failed after porting from qa scope to eth 👍
src/test/scala/io/iohk/ethereum/jsonrpc/JsonRpcControllerSpec.scala
Outdated
Show resolved
Hide resolved
65c8b04 to
712a173
Compare
Done. |
mmrozek
reviewed
Oct 15, 2020
| @@ -961,6 +961,43 @@ | |||
| "settingFollowRedirects": "global", | |||
| "_type": "request" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Please remove qa_getPendingTransactions from insomnia also
There was a problem hiding this comment.
And remember to notify QA once this gets merged :)
5b14e23 to
2d8c97e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Ethereum JSON-RPC endpoint eth_pendingTransactions
Proposed Solution
Important Changes Introduced
Testing