Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-118] Remove OldRegularSync from codebase #691

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

ajuszczak
Copy link
Contributor

@ajuszczak ajuszczak commented Sep 23, 2020

Description

This pull requests removes implementation for OldRegularSync since we are not going to use it anymore and it might be misleading while talking about implementation of RegularSync.

Important Changes Introduced

use-new-regular-sync has been removed from the configuration file, since only RegularSync is supported.

@ntallar
Copy link

ntallar commented Sep 25, 2020

I'll take ownership of this PR as Adrian no longer works on Mantis

@ntallar ntallar requested review from mmrozek and removed request for kapke and KonradStaniec September 28, 2020 12:02
Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ntallar ntallar merged commit 51be0f4 into develop Sep 28, 2020
@ntallar ntallar deleted the ETCM-118-remove-old-regular-sync branch September 28, 2020 13:56
@ntallar ntallar added the BREAKS CONFIG Affects the default configuration label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKS CONFIG Affects the default configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants