Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Testnet config #663

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[CHORE] Testnet config #663

merged 1 commit into from
Sep 11, 2020

Conversation

mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Sep 11, 2020

Description

Initial config for the private testnet:

  1. Node syncs using regular sync
  2. Mining is enabled
  3. Phoenix fork config will be a base for chain
  4. Disabled features:
  • pruning
  • discovery
  • blacklisting

Copy link
Contributor

@kaii-zen kaii-zen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry-picked the commit on top of chore/update-sbt-add-nix and it seems to make my problems go away so :shipit: plz

}

blockchains {
network = "private"
}

consensus {
coinbase = "0011223344556677889900112233445566778899" # has to be changed for each node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is part of the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to have anything here(it is the default from application.conf). For each node, we have to obtain a different account

Copy link
Contributor

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment to double check, also you need to sign your commit :)

dao = null
bootstrap-nodes = []
include "base.conf"
frontier-block-number = "0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would double check if we do not have some boolean conflicts when are block numbers are equal to 0 (like in ets test sometimes we have fork block equal to -1 to keep the ordering between forks)

@mmrozek mmrozek force-pushed the private-testnet-config branch from 4c0cc3d to 22c5051 Compare September 11, 2020 12:30
@mirkoAlic mirkoAlic merged commit c374985 into develop Sep 11, 2020
@mirkoAlic mirkoAlic deleted the private-testnet-config branch September 11, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants