Etcm 1030 #1069
Merged
Etcm 1030 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-bogastry
approved these changes
Jul 22, 2021
strauss-m
reviewed
Jul 22, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/ExecutionSync.scala
Outdated
Show resolved
Hide resolved
strauss-m
approved these changes
Jul 22, 2021
jvdp
reviewed
Jul 23, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/ExecutionSync.scala
Outdated
Show resolved
Hide resolved
jvdp
reviewed
Jul 23, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/PeersClient.scala
Outdated
Show resolved
Hide resolved
jvdp
reviewed
Jul 23, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporterService.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/HeadersFetcher.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/FetcherService.scala
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
|
|
||
| //not used atm, a part of the future ExecutionSync | ||
| class FetcherService(validator: BlockValidator, blockchainReader: BlockchainReader, syncConfig: SyncConfig) { | ||
| val batchSize = syncConfig.blockHeadersPerRequest |
There was a problem hiding this comment.
I think that this is an unfortunate pattern. the class does not depend on the whole sysconfig class - it depends on one field from that class. how can we better express such dependencies?
if it's one field perhaps a tagged number would be good enough?
There was a problem hiding this comment.
I'm not sure I know what's a tagged number🤔
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/FetcherService.scala
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/FetcherService.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/FetcherService.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
| val endNumber: Option[BigInt] = | ||
| fetchUntilBlock.fold(Some(_), blockchainReader.getBlockHeaderByHash(_).map(_.number)) | ||
| val startNumber: Option[BigInt] = | ||
| startFromBlock.fold(Some(_), blockchainReader.getBlockHeaderByHash(_).map(_.number)) |
There was a problem hiding this comment.
correct me if I'm wrong but wouldn't it be beneficial to request a block by hash from a peer?
There was a problem hiding this comment.
actually thinking more on that - we wouldn't know the hash of the block we want to fetch from the peer if we don't have that block ourselves. And the point of fetching from multiple peers is exactly to get alternative chains, so we do need to fetch by number here
dzajkowski
requested changes
Jul 25, 2021
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/PeersClient.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Jul 25, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/PeersClient.scala
Outdated
Show resolved
Hide resolved
f8dcd4e to
a51b6c8
Compare
AurelienRichez
approved these changes
Jul 27, 2021
dzajkowski
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExecutionSync is gonna be orchestrating the whole regular sync process and is gonna replace current RegularSync class.
Note: tests will be added in a separate PR