Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-841] Consume remaining data when extracting Hello in order #1019

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

dzajkowski
Copy link
Contributor

FrameCodec holds Secrets which is a mutable structure. The unfortunate reality is that it cannot identify that it is reading a message out of order. This goes exactly in opposite to how akka actors handle messages and can cause Frame deserialization to throw a "MAC mismatch" exception.

The fix is to cause the FrameCodec to read any available data immediately and not reschedule it to a mailbox.

@dzajkowski dzajkowski force-pushed the bugfix/etcm-841-consume-remaining-data-in-order branch from ea50d69 to b395772 Compare June 18, 2021 13:49
@dzajkowski dzajkowski force-pushed the bugfix/etcm-841-consume-remaining-data-in-order branch from 687b785 to 4c300d4 Compare June 21, 2021 20:14
@dzajkowski dzajkowski merged commit c3abf45 into develop Jun 21, 2021
@dzajkowski dzajkowski deleted the bugfix/etcm-841-consume-remaining-data-in-order branch June 21, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants