Add exceptions and stm to nonReinstallablePkgs for ghc901 #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not merge #1183 because we were concerned that it would change the exceptions and stm used for users that did not want to build GHC. However `reinstallableLibGhc = true` is now the default and most projects should not be setting it to `false`. That means this change will now only affect projects that likely want to use the built in `ghc` package.
5cd2994 to
06a22d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not merge #1183 because we were concerned that it would change the exceptions and stm used for users that did not want to build GHC. However
reinstallableLibGhc = trueis now the default and most projects should not be setting it tofalse. That means this change will now only affect projects that likely want to use the built inghcpackage.