Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around for packages in lts that do not install. #1437

Merged
merged 15 commits into from
Apr 20, 2022
Merged

Conversation

hamishmack
Copy link
Collaborator

@hamishmack hamishmack commented Apr 12, 2022

For ghc 9.0.2 Haskell.nix will use the stmand filepath source that came with ghc when the version desired matches. This is because 9.0.2 shipped with packages that differ from the same version in hackage.

reinstallableLibGhc is fixed for GHC 8.10 and above. Rather than including a patch file this works by:

  • Setting the subDir to the compiler directory when building. That way relative paths to other parts of the ghc source tree (outside the compiler directory) still work.
  • Files that are needed, but generated when ghc builds are added from the generated output of the ghc derivation.

nonReinstallablePkgs is now sorted and deduplicated before it is used (this reduces the chance of rebuilds when the list is refactored).

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 12, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 12, 2022

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 14, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 14, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 14, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 14, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 15, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 15, 2022

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 15, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 15, 2022

try

Timed out.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 15, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 15, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 19, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 19, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 19, 2022
@hamishmack hamishmack requested a review from angerman April 19, 2022 08:54
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 19, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 20, 2022
@hamishmack
Copy link
Collaborator Author

bors try-

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 20, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 20, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant