Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Daedalus wallet recovery: address payload of infinite size bug make cardano-cli crash #73

Closed
backuitist opened this issue Nov 23, 2018 · 19 comments · Fixed by #86
Closed
Assignees
Labels
bug Something isn't working

Comments

@backuitist
Copy link

backuitist commented Nov 23, 2018

Running cardano-cli wallet sync mywallet

syncing wallet from 82.13 to 85.2368
⠙ [00:00:00] [###>------------------------------------] 6064/67155 (3s)
memory allocation of 18446744073709551613 bytes failed

Looks like a bit too much memory.

* wallet model RandomIndex2Levels
 * derivation scheme V1
 * synced to block  9eab5304cc7a5d8106606f99966b14f458e99798d38e547da37e30740a7936f2 (82.13)
@endline
Copy link

endline commented Dec 17, 2018

same issue on mac os 10.13.6

stable-x86_64-apple-darwin

@endline
Copy link

endline commented Dec 18, 2018

ill note that this only occurs when claiming then syncing a daedalus wallet.

running the below completes fine 👍

cardano-cli wallet create <wallet>
cardano-cli wallet attach <wallet> mainnet
cardano-cli wallet sync wallet

@NicolasDP
Copy link
Contributor

thanks, this is very valuable details. I think I can pin down a bit the problem now.

@NicolasDP NicolasDP self-assigned this Dec 18, 2018
@NicolasDP NicolasDP added the bug Something isn't working label Dec 18, 2018
@NicolasDP NicolasDP changed the title Crash while syncing due to memory allocation Daedalus's address payload of infinite size bug make cardano-cli crash when running wallet recovery Dec 18, 2018
@NicolasDP NicolasDP changed the title Daedalus's address payload of infinite size bug make cardano-cli crash when running wallet recovery Daedalus wallet recovery: address payload of infinite size bug make cardano-cli crash Dec 18, 2018
@endline
Copy link

endline commented Dec 18, 2018

@NicolasDP 👊

@NicolasDP
Copy link
Contributor

the fix is in latest SDK, but I'll still need to update the cli now to utilise this fix.

@NicolasDP
Copy link
Contributor

this has now been fixed

@endline
Copy link

endline commented Dec 21, 2018

fyi, after updating and rebuilding i still have the issue for my daedalus claimed wallet.
perhaps i am missing something?

@NicolasDP
Copy link
Contributor

do you have the error:

Error while decoding an address' payload

@NicolasDP
Copy link
Contributor

NicolasDP commented Dec 21, 2018

Ok I closed it because I thought the problem was that it was having a panic when seeing the invalid addresses. But the actual problem is that it is impossible to retrieve an address beyond block bb1d04fc641b856f40a51f723251aa99a818dd395ca35436210aafafc165c1a7 where there are addresses that are of invalid sizes.

@NicolasDP
Copy link
Contributor

lastest commit should work fine now

@endline
Copy link

endline commented Dec 22, 2018

i still get the aforementioned

$ cardano-cli wallet sync EndlineWallet
...
syncing wallet from 82.13 to 90.18046
⠒ [00:00:02] [#>--------------------------------------] 6671/190833 (1m)
memory allocation of 18446744073709551613 bytes failedAbort trap: 6

now attempting a detach and re attach + sync

@endline
Copy link

endline commented Dec 22, 2018

hmm. no dice.

syncing wallet from 0.GENESIS to 90.18046
⠁ [00:13:45] [####################################>---] 1777389/1962046 (1m)
memory allocation of 18446744073709551613 bytes failedAbort trap: 6

@NicolasDP
Copy link
Contributor

NicolasDP commented Dec 22, 2018

are you using the latest commit on master branch 8b29bb892c7c9a9540148d42ec9fbcfaecc265ac ?

@endline
Copy link

endline commented Dec 22, 2018

yes indeed.

$ git log -n 1
commit 8b29bb892c7c9a9540148d42ec9fbcfaecc265ac (HEAD -> master, origin/master, origin/HEAD)
Merge: 062eb13 47ab936
Author: Nicolas Di Prima <nicolas@primetype.co.uk>
Date:   Fri Dec 21 23:40:50 2018 +0000

    Merge pull request #86 from input-output-hk/ignore-invalid-addresses

    Ignore invalid addresses

@endline
Copy link

endline commented Dec 22, 2018

either way, this is no longer an issue for me personally. as i have moved on to other wallets.
yet more or less to get to the bottom of things.

@NicolasDP
Copy link
Contributor

ok, thanks for the feedbacks. I cannot reproduce your error with the last changes.

NicolasDP added a commit that referenced this issue Dec 22, 2018
@endline
Copy link

endline commented Dec 22, 2018

cool. thanks for ur efforts.
i will reply on this issue if i come up with a fix for this.

@gsovereignty
Copy link
Contributor

I'm having the same issue with the current master branch.

memory allocation of 18446744073709551613 bytes failed

Do you want any backtrace or anything?

@mzabaluev
Copy link
Contributor

Yes, please post the backtrace with RUST_BACKTRACE=1 in the environment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants