Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated release with Semantic Release #32

Merged
merged 137 commits into from
Oct 9, 2023
Merged

Automated release with Semantic Release #32

merged 137 commits into from
Oct 9, 2023

Conversation

dottxado
Copy link
Contributor

@dottxado dottxado commented Jan 17, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?
With this PR I would like to add a new workflow that uses Semantic Release.
It is lightly based on the workflow my team has used for years.
Semantic release requires a release.config.js file in order to configure the plugins that are needed during the release process. This file is created by the workflow, so there is no more need for that file inside the caller repository, unless you are releasing a custom package and you want to provide that file.

The release.config.js file is generated from a template with basic setups. Refer to the documentation page for more specifications.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting very close. Thanks for incorporating all the changes!

But: 
> Packages based on yarn will not be released using this automation. 

Wait, I was not aware of this! 🤯 Looks like we definitely need to decide on a package manager, and should we decide on yarn, switch to https://github.com/hongaar/semantic-release-yarn.

Edit: This is not correct.

@dottxado dottxado requested a review from tyrann0us October 1, 2023 11:57
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dottxado, thank you very much for working on this. Never tested this personally but code-wise LGTM.

@dottxado dottxado dismissed luislard’s stale review October 9, 2023 08:00

old review, already addressed everything

@dottxado dottxado merged commit 9aa0a58 into main Oct 9, 2023
@dottxado dottxado deleted the automatic-release branch October 9, 2023 09:07
@dottxado dottxado removed the on hold Pull requests that update a dependency file label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants