-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube - Hide ads): Add Hide end screen store banner
setting
#131
Conversation
related to this PR, a more dynamic way of dealing with these ads, is to use the custom litho filter:
|
not works on my device |
then it was removed in the latest versions, all i can say is that it works up to version v19.16.39 |
I just found out that 01-19 22:10:30.625 31672 31672 D revanced: LithoFilterPatch: Searching ID: fullscreen_overlay.eml|496944a54432aa3f Path: fullscreen_overlay.eml|496944a54432aa3f|fullscreen_overlay_inner.eml|961931b64543ed2c|CellType| BufferStrings: button.eml|713fd10bcb423d23❙From ❙1,428.07❙sans-serif-regular❙sans-serif-regular❙12 products❙sans-serif-regular❙Shelby's Canada store❙sans-serif-regular❙https://encrypted-tbn2.gstatic.com/shopping? |
yes, |
That's something I guess. At least the ad part will be gone. |
yeah, even though it's not very polished, it might be worth adding a toggle for that filter as an experimental flag |
Nah, just add a limitation saying that the outline will remain. That should be enough. |
that's what I meant |
can you also find custom filters for remaining items (title and channel)? i think something can be done about the outline |
going through my log i tested:
these are hard to test individually, but they removes the button to close the fullscreen video, and all the contents inside te dividers you sent. no luck on those dividers:
maybe that component is created before going to fullscreen? the last thing i noticed, it that the request for loading the content of that type of ad is coming from: last tested
|
none of these filters hide video title in related video overlay😥 |
Instead of changing the height or width of the layout to 0 in xml, it's better to implement hiding components programmatically. This PR could be replaced by ReVanced/revanced-patches#4351. With this method, the end screen store banner is not completely hidden (Empty space remains). So I implemented the patch in a different way.
|
Hide end screen store banner
setting
Hide end screen store banner
off:Hide end screen store banner
on: