Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube - RVX settings): Match RVX settings UI with YouTube settings #249

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Feb 12, 2023 · 6 comments
Labels
Suggestion Leave any other suggestions

Comments

@ILoveOpenSourceApplications

Application

YouTube

Issue

Add back button on the top left for every sub category pages under ReVanced Extended Settings along with their own titles just like the initial settings page after clicking the same.
Main RVX Settings page:
Screenshot_20230212-144729~2
Why the seperation in between, where one is titled ReVanced settings and the other ReVanced Extended Settings? Some of those patches are unique to extended and not present in ReVanced and hence I don't understand this seperation.

One of the sub settings page:
Screenshot_20230212-145121~2
Also rename the main settings title to ReVanced Extended settings rather than ReVanced settings and remove the title under it.
Screenshot_20230212-145331~2

Patch

As mentioned above in issues.

Motivation

Revanced Extended, though a fork of ReVanced, is still progressing and considering the request of its users and progressing steadily. Hence it should have its own unique identity throughout the UI.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Feature request Requesting a new feature label Feb 12, 2023
@inotia00 inotia00 added Suggestion Leave any other suggestions and removed Feature request Requesting a new feature labels Feb 13, 2023
@inotia00 inotia00 changed the title feat(patch): Refining ReVanced Extended Settings suggestion: Refining ReVanced Extended Settings Feb 13, 2023
@inotia00
Copy link
Owner

reflected in revanced-patches-v2.162.1

@ILoveOpenSourceApplications
Copy link
Author

Screenshot_20230218-141906~2
Is this really necessary, to have a title below the ReVanced Extended settings title in the settings bar.

Also I believe out of my suggestions only some got implemented and hence I believe this can't be closed now right?

@inotia00
Copy link
Owner

Only acceptable suggestions were partially reflected

The reason this issue is closed is because there are no plans to reflect the rest of the suggestions.

If there are any changes to the official ReVanced, they will be reflected.

@ILoveOpenSourceApplications
Copy link
Author

Screenshot_20230218-141906~2 Is this really necessary, to have a title below the ReVanced Extended settings title in the settings bar.

Can't atleast this be implemented then? As ReVanced Extended settings is the only option having a subtitle to the original title, yes it sticks out but aesthetically it's not nice.

@inotia00
Copy link
Owner

inotia00 commented Feb 21, 2023

Screenshot_20230218-141906~2 Is this really necessary, to have a title below the ReVanced Extended settings title in the settings bar.

Can't atleast this be implemented then? As ReVanced Extended settings is the only option having a subtitle to the original title, yes it sticks out but aesthetically it's not nice.

reflected in revanced-patches-v2.162.7

@ILoveOpenSourceApplications
Copy link
Author

Thanks!

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title suggestion: Refining ReVanced Extended Settings suggestion(YouTube - RVX settings): Match RVX settings UI with YouTube settings Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

2 participants