Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch for using pypdfium2 #3

Closed
wants to merge 2 commits into from
Closed

patch for using pypdfium2 #3

wants to merge 2 commits into from

Conversation

mara004
Copy link
Contributor

@mara004 mara004 commented Nov 21, 2021 •
edited
Loading

pypdfium2 is not published yet, but when it's out, you could consider switching, as that's where regular updates are planned. If you are only using the PDFium API, pypdfium2 should be fully compatible with the original pypdfium.

@mara004 mara004 marked this pull request as draft November 21, 2021 10:10
@mara004 mara004 changed the title patch for using pypdfium2 patch for using (unpublished) pypdfium2 Nov 21, 2021
@mara004
Copy link
Contributor Author

mara004 commented Nov 21, 2021

I'm not sure, but maybe you could even merge parts of pdfbrain into upstream pypdfium2? Our support model code is in _helpers.py if you want to take a look. I had already been thinking about adding document and page support classes...

@mara004 mara004 marked this pull request as ready for review December 3, 2021 15:02
@mara004
Copy link
Contributor Author

mara004 commented Dec 3, 2021 •
edited
Loading

PyPDFium2 is published now and released on PyPI.

@mara004 mara004 changed the title patch for using (unpublished) pypdfium2 patch for using pypdfium2 Dec 3, 2021
@mkroutikov
Copy link
Contributor

Switched to pypdfium2 in a separate branch. Thank you for providing pypdfium2!

Re: merging pdfbrain into pypdfium2: I think its premature, as pdfbrain is still pretty much an experiment. I'd like to have a freedom to change API, and experiment with text extraction.

Closing this PR

@mkroutikov mkroutikov closed this Jun 21, 2022
@mara004
Copy link
Contributor Author

mara004 commented Jun 21, 2022

Thanks!
A small suggestion: You can do import pypdfium2._pypdfium as pdfium so that you only get the ctypesgen bindings and no pypdfium2 support model code, to keep the namespace cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mara004 @mkroutikov