Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove twoslash, fix other deps #289

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Remove twoslash, fix other deps #289

merged 6 commits into from
Jan 7, 2023

Conversation

djfarrelly
Copy link
Member

@djfarrelly djfarrelly commented Jan 5, 2023 •
edited
Loading

Description

The remark Twoslash plugin is incompatible with newer MDX plugins, so we remove it for now.

TODO

  • Replace twoslash with vanilla shiki
  • Modify shiki to match DOM structure of twoslash so design doesn't change
  • Remove code from docs/blog/etc. that uses twoslash markup

See

@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website ✅ Ready (Inspect) Visit Preview Jan 7, 2023 at 0:41AM (UTC)

@djfarrelly djfarrelly merged commit 178e05a into feat/docs Jan 7, 2023
@djfarrelly djfarrelly deleted the fix/docs-deps branch January 7, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djfarrelly