Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make in-band syncing opt-out #184

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Make in-band syncing opt-out #184

merged 2 commits into from
Jan 9, 2025

Conversation

amh4r
Copy link
Collaborator

@amh4r amh4r commented Nov 26, 2024

Changes

  • Change in-band syncing to opt-out. It's currently opt-in.
  • Rename a test to missing_sync_kind_header.
  • Add test for opting out of in-band syncs.
  • Change VS Code settings to format on save.

Context

The Inngest server asks the SDK to perform an in-band sync via the x-inngest-sync-kind header. The SDK can still perform an out-of-band sync if it chooses; the Inngest server does not require an in-band response.

@amh4r amh4r merged commit bc94c48 into main Jan 9, 2025
10 checks passed
@amh4r amh4r deleted the in-band-sync-opt-out branch January 9, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants