Fix step state incorrect type when returning null from steps
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix the `step state incorrect type` that was being thrown when a step returns a null result.
KiKoS0
commented
Jan 17, 2025
There was a problem hiding this comment.
This was just a showcase poc of the bug, I'll be dropping the commit before merging.
There was a problem hiding this comment.
I see it failing before and working after 👍
albertchae
approved these changes
Jan 17, 2025
Comment on lines
-106
to
-108
| if (stepResult != null) { | ||
| return stepResult | ||
| } |
There was a problem hiding this comment.
looks like we inadvertently introduced this bug with #19
There was a problem hiding this comment.
i believe it was always present because even the older version check returns false when type checking a null result, because null can never be a specific type:
val stepResult = state.getState<T>(hashedId)
if (stepResult is T) {i made sure it's the case with this generic example:
inline fun <reified T> isOfType(value: Any?): Boolean {
return value is T
}
fun main() {
println(isOfType<String>(null))
}There was a problem hiding this comment.
awesome, thanks for verifying
| stepResult.has(fieldName) -> deserializeStepData(stepResult.get(fieldName), type) | ||
| stepResult.has("error") -> throw mapper.treeToValue(stepResult.get("error"), StepError::class.java) | ||
| // NOTE - Sleep steps will be stored as null | ||
| stepResult is NullNode -> null |
There was a problem hiding this comment.
I see it failing before and working after 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should fix the
step state incorrect typethat was beingthrown when a step returns a
nullresult.Changes:
Allow returning a
nullvalue from thedatafield of a step forstep.run.Make sure the
datafield is anulljson node forstep.sleep. Here's the memoized state payload sent to the JS sdk which the Kotlin code is closely following:{ "steps": { "c3ca5f787365eae0dea86250e27d476406956478": null, "244fb75b19415c9ee4f143b34b4b241236fb63f5": { "data": null } } }Checklist
Related
https://inngest.slack.com/archives/C06KB85RXRV/p1736536607871969