-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring boot demo application version 2.7.18 #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paired on this together, there are still some outstanding issues as detailed in the PR description but we figured out enough of the Java 8 compilation that we thought it was worth merging something now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
could you add the command you use to run spring boot server before you merge?
} | ||
} | ||
|
||
// NOTE: We probably don't need this singleton anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current SDK standards are to no expose any of the handlers to the users, and they can either,
- mount our route onto their HTTP controller
- directly create the HTTP endpoint for them
I'd imagine Java will be the former, so the singleton shouldn't exist and only the controller should be there.
we need to figure out this out still 😅 , for now we were just running via IntelliJ EDIT: #15 |
implementation("com.fasterxml.jackson.core:jackson-databind:2.16.1") | ||
implementation("com.squareup.okhttp3:okhttp:4.12.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okhttp is licensed under Apache 2.0 https://github.com/square/okhttp/blob/master/LICENSE.txt
inngest-core
to Java 8 so that Java 8 apps can consume it. This meant we couldn't use Java httpclient which was introduced in Java 11.step.run
currently is.inngest-kt/inngest-core/src/main/kotlin/com/inngest/Step.kt
Line 28 in e9a6a15