Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React deprecation warning - use 'prop-types' package #6

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Fix React deprecation warning - use 'prop-types' package #6

merged 1 commit into from
Aug 21, 2017

Conversation

inlinestyle
Copy link
Owner

Hi 👋 !
The latest versions of React emit a deprecation warning when React.PropTypes is used. This PR makes the recommended change to using the standalone prop-types package. It also adds prop-types as a peer dependency.

Let me know if any changes are needed!

Documentation: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes.

@bebraw
Copy link
Collaborator

bebraw commented Aug 21, 2017

Thanks! Published as 0.6.0.

Note that I don't use the package actively anymore so let me know if you want to take over. I can set up rights etc.

@inlinestyle
Copy link
Owner Author

@bebraw sure! I'd be happy to be a maintainer or co-owner.

@bebraw
Copy link
Collaborator

bebraw commented Aug 22, 2017

@inlinestyle Ok, cool. I added you as a collaborator to the repository. You can also publish new versions of the package. I don't mind moving the package below your account either if you want (no strong opinion on that).

@inlinestyle
Copy link
Owner Author

@bebraw I'd say move it if you don't want to get @-mentioned anymore? Do you still want to review changes?

@bebraw
Copy link
Collaborator

bebraw commented Aug 22, 2017

@inlinestyle Ok, I'll move then. You have to remove your personal fork to enable the move. Good to go after that.

@inlinestyle inlinestyle deleted the by-prop-types branch August 22, 2017 14:44
@inlinestyle
Copy link
Owner Author

@bebraw done!

@inlinestyle
Copy link
Owner Author

@bebraw thanks! I'll stop pinging you now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants